On environments whose global sql_mode is empty — most notably Amazon RDS and Aurora MySQL default parameter groups — appending only STRICT_ALL_TABLES leaves out NO_ZERO_IN_DATE, NO_ZERO_DATE, and ERROR_FOR_DIVISION_BY_ZERO, which MySQL 5.7+ has otherwise made part of its own default. Appending TRADITIONAL closes the gap.

---

Append `TRADITIONAL` instead of `STRICT_ALL_TABLES` to MySQL’s `sql_mode` by default by kamipo · Pull Request #58350 · rails/rails · GitHub

Skip to content

Navigation Menu

Sign in

Appearance settings

• Platform

  • AI CODE CREATION

    • GitHub CopilotWrite better code with AI
    • GitHub Copilot appDirect agents from issue to merge
    • MCP RegistryIntegrate external tools

  • DEVELOPER WORKFLOWS

    • ActionsAutomate any workflow
    • CodespacesInstant dev environments
    • IssuesPlan and track work
    • Code ReviewManage code changes
    • Code QualityEnforce quality at merge

  • APPLICATION SECURITY

    • GitHub Advanced SecurityFind and fix vulnerabilities
    • Code securitySecure your code as you build
    • Secret protectionStop leaks before they start

  • EXPLORE

    • Why GitHub
    • Documentation
    • Blog
    • Changelog
    • Marketplace

  View all features

• Solutions

  • BY COMPANY SIZE

    • Enterprises
    • Small and medium teams
    • Startups
    • Nonprofits

  • BY USE CASE

    • App Modernization
    • DevSecOps
    • DevOps
    • CI/CD
    • View all use cases

  • BY INDUSTRY

    • Healthcare
    • Financial services
    • Manufacturing
    • Government
    • View all industries

  View all solutions

• Resources

  • EXPLORE BY TOPIC

    • AI
    • Software Development
    • DevOps
    • Security
    • View all topics

  • EXPLORE BY TYPE

    • Customer stories
    • Events & webinars
    • Ebooks & reports
    • Business insights
    • GitHub Skills

  • SUPPORT & SERVICES

    • Documentation
    • Customer support
    • Community forum
    • Trust center
    • Partners

  View all resources

• Open Source

  • COMMUNITY

    • GitHub SponsorsFund open source developers

  • PROGRAMS

    • Security Lab
    • Maintainer Community
    • Accelerator
    • GitHub Stars
    • Archive Program

  • REPOSITORIES

    • Topics
    • Trending
    • Collections

• Enterprise

  • ENTERPRISE SOLUTIONS

    • Enterprise platformAI-powered developer platform

  • AVAILABLE ADD-ONS

    • GitHub Advanced SecurityEnterprise-grade security features
    • Copilot for BusinessEnterprise-grade AI features
    • Premium SupportEnterprise-grade 24/7 support

• Pricing

Search/

Sign in

Sign up

Appearance settings

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session. Dismiss alert

Uh oh!

There was an error while loading. Please reload this page.

rails / rails Public

• Notifications You must be signed in to change notification settings
• Fork 22.4k

• Star 58.7k

• Code
• Issues 485
• Pull requests 1.1k
• Discussions
• Actions
• Security and quality 26
• Insights

Additional navigation options

• Code
• Issues
• Pull requests
• Discussions
• Actions
• Security and quality
• Insights

Append TRADITIONAL instead of STRICT_ALL_TABLES to MySQL’s sql_mode by default - #58350

#58350

Merged

kamipo merged 1 commit into

rails:mainrails/rails:mainfrom

kamipo:mysql_default_sql_mode_traditionalkamipo/rails:mysql_default_sql_mode_traditionalCopy head branch name to clipboard

Aug 9, 2026

ConversationCommits1 (1)ChecksFiles changed

Merged

##

Append TRADITIONAL instead of STRICT_ALL_TABLES to MySQL’s sql_mode by default#58350

kamipo merged 1 commit into

rails:mainrails/rails:mainfrom

kamipo:mysql_default_sql_mode_traditionalkamipo/rails:mysql_default_sql_mode_traditionalCopy head branch name to clipboard

Conversation

###

kamipo commented Aug 3, 2026

Copy link

Copy Markdown

Member

On environments whose global sql_mode is empty — most notably Amazon RDS and Aurora MySQL default parameter groups — appending only STRICT_ALL_TABLES leaves out NO_ZERO_IN_DATE, NO_ZERO_DATE, and ERROR_FOR_DIVISION_BY_ZERO, which MySQL 5.7+ has otherwise made part of its own default. Empty-sql_mode environments were expected to fade with MySQL 5.7+ adoption, but they haven’t.

As #57077 noted when deprecating the strict: false option, silently accepting invalid values is not a recommended default for modern applications. Appending TRADITIONAL closes the gap so the recommended behavior holds regardless of what sql_mode the server happens to default to.

Reproducing the previous behavior is possible via variables: { sql_mode: "STRICT_ALL_TABLES" } in database.yml.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions github-actions Bot added the activerecord label Aug 3, 2026

[Append `TRADITIONAL` instead of `STRICT_ALL_TABLES` to MySQL's `sql_m…](/rails/rails/pull/58350/commits/64fb6b14419b2d4a2254889571554297fcba4c6f "Append `TRADITIONAL` instead of `STRICT_ALL_TABLES` to MySQL's `sql_mode` by default On environments whose global `sql_mode` is empty — most notably Amazon RDS and Aurora MySQL default parameter groups — appending only `STRICT_ALL_TABLES` leaves out `NO_ZERO_IN_DATE`, `NO_ZERO_DATE`, and `ERROR_FOR_DIVISION_BY_ZERO`, which MySQL 5.7+ has otherwise made part of its own default. Empty-`sql_mode` environments were expected to fade with MySQL 5.7+ adoption, but they haven't. As #57077 noted when deprecating the `strict: false` option, silently accepting invalid values is not a recommended default for modern applications. Appending `TRADITIONAL` closes the gap so the recommended behavior holds regardless of what `sql_mode` the server happens to default to. Reproducing the previous behavior is possible via `variables: { sql_mode: \"STRICT_ALL_TABLES\" }` in `database.yml`.") …

[64fb6b1](/rails/rails/pull/58350/commits/64fb6b14419b2d4a2254889571554297fcba4c6f)

…ode` by default

On environments whose global `sql_mode` is empty — most notably Amazon RDS and Aurora MySQL default parameter groups — appending only `STRICT_ALL_TABLES` leaves out `NO_ZERO_IN_DATE`, `NO_ZERO_DATE`, and `ERROR_FOR_DIVISION_BY_ZERO`, which MySQL 5.7+ has otherwise made part of its own default. Empty-`sql_mode` environments were expected to fade with MySQL 5.7+ adoption, but they haven’t.

As rails#57077 noted when deprecating the `strict: false` option, silently accepting invalid values is not a recommended default for modern applications. Appending `TRADITIONAL` closes the gap so the recommended behavior holds regardless of what `sql_mode` the server happens to default to.

Reproducing the previous behavior is possible via `variables: { sql_mode: “STRICT_ALL_TABLES” }` in `database.yml`.

kamipo force-pushed the mysql_default_sql_mode_traditional branch from d1ad843 to 64fb6b1 Compare August 9, 2026 10:37

Hide details View details

kamipo merged commit a24a698 into rails:main Aug 9, 2026

5 checks passed

Uh oh!

There was an error while loading. Please reload this page.

kamipo deleted the mysql_default_sql_mode_traditional branch August 9, 2026 11:35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

### Reviewers

No reviews

Assignees

No one assigned

Labels

activerecord

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Footer

© 2026 GitHub, Inc.

Footer navigation

• Terms
• Privacy
• Security
• Status
• Community
• Docs
• Contact
• Manage cookies
• Do not share my personal information

You can’t perform that action at this time.